Refactor: Simplify TransactionState #5078
Open
+144
−314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
force-pushed
the
simplify_transaction_state
branch
from
3612225 to
b6afccc
Compare
tao-stones
reviewed
Feb 27, 2025
| /// The transaction is currently scheduled or being processed. | ||
| Pending { priority: u64, cost: u64 }, | ||
| /// Only used during transition. | ||
| Transitioning, |
There was a problem hiding this comment.
Happy to see Transitioning is gone - always think transitioning between states itself is not a state.
| /// Priority of the transaction. | ||
| priority: u64, | ||
| /// Estimated cost of the transaction. | ||
| cost: u64, |
There was a problem hiding this comment.
looks like max_age, priority and cost are properties associated with transaction that's ready for processing. If so, they can be bundled together to better describe "state", could also make container.insert_new_transaction( tx_with_its_properties ) cleaner. wdyt something like this instead of option<Tx>?
enum TransactionState<Tx> {
Unprocessed {
transaction: Tx,
max_age: MaxAge,
priority: u64,
cost: u64,
// or define a struct for above 4 fields
},
Processing,
}
There was a problem hiding this comment.
Think it's fine to make a bundle of these, but only few actually need to be sent with the other items for processing (only max_age currently).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TransactionStateused to contain raw packet information but it makes more sense for the state to be flat w/ a simple internal option now.Summary of Changes
SanitizedTransactionTTLFixes #